Helix-Machines deployment parameter hash is insufficient

[chcosta]

During deployments, we calculate a hash of deployment parameters which we use to determine whether anything has changed in an image definition (definitions/shared/*). That code piece appears to have decayed a bit and not been kept up to date as the schema for our definitions is modified. We should either take a pass and update the code, or refactor it to automatedly determine / compare parameter values.

Deployment parameter hash function: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines?path=/src/DeployQueues/QueueManager.cs&version=GCa27e0dbf09977a1b51b56ae775aabf1d272ea5a0&line=873&lineEnd=903&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

Related issue: #4156

Release Note Category

• Feature changes/additions
• Bug fixes
• Internal Infrastructure Improvements

Release Note Description

[dougbu]

IIRC bits are missing from the hash b/c the returned information lacks the necessary information. do you have an example of something that is returned but is ignored in the hash calculation❓