Xplat native build with existing artifacts doesn't rebuild if only symbol stripping configuration has changed

[dagood]

CMake (or Make) doesn't rebuild the xplat binaries when -stripSymbols is set differently than the command that built what's in bin. Symbol stripping happens on build, so this means someone might run a "successful" build command that ends up with unexpected outputs in this very specific case. Repro:

1. Perform the native CoreFX build without stripping symbols (default).
2. Perform a native CoreFX build again with stripping enabled.
3. The native build doesn't detect any changes, and doesn't rebuild, leaving you with unstripped binaries.

Workaround: clean the native artifacts to force a new build.

This was a known issue introduced with dotnet/corefx#15440.

/cc @ellismg

[wtgodbe]

@dagood is this still an issue?

[dagood]

Yes, it still repros as of 70e7e11.

[ViktorHofer]

I'm surprised that this still applies as our native build isn't incremental.

[dagood]

Huh, it always has been in my experience, and it is currently in Core-Setup at least.

(I haven't built CoreFX in a while though.)

[ViktorHofer]

It's incremental now again in corefx as that was fixed recently. I'm not exactly sure what the action item here is (this is currently the oldest issue on our infra backlog). @dagood do you have suggestions?

[dagood]

If the issue is something that someone cares to fix, I would first verify the repro steps (although I really doubt it's been accidentally fixed), then fix it:

1. Perform the native CoreFX build without stripping symbols (default).
2. Perform a native CoreFX build again with stripping enabled.
3. The native build doesn't detect any changes, and doesn't rebuild, leaving you with unstripped binaries.

I doubt it's a big issue if the dev is aware of it, or in general suspects the incremental build is causing problems (the workaround--a fresh build--is pretty typical), however it could be a very headache-inducing surprise.

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.