ConfigurationBinder source generator build fails with CS9035 if option class have Property with requried

[xmarshal]

Description

ConfigurationBinder source generator generates code that doesn't compile when using recodrs with requried properties as option Property

Reproduction Steps

build this code

namespace BindGeneratorRepro;

using System.Reflection;

internal class Program
{
    private static void Main(string[] args)
    {
        var builder = WebApplication.CreateSlimBuilder(args);

        builder.Services.AddOptions();

        builder.Services.AddOptions<MyOptionA>()
            .BindConfiguration("myPath", options => options.BindNonPublicProperties = true);

        var app = builder.Build();

        app.MapGet("/version", () =>
        {
            var fileVersionAttribute = Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyFileVersionAttribute>();

            return Results.Text(fileVersionAttribute!.Version);
        });

        app.Run();
    }
}

internal sealed record MyOptionA
{
    public required string MyParamA { get; init; }
    public required MyOptionB MyParamAB { get; init; }
}

internal sealed record MyOptionB
{
    public required string MyParamB { get; init; }
}

Expected behavior

Code should compiles

Actual behavior

build files with error CS9035
BinGeneratorRepro\Microsoft.Extensions.Configuration.Binder.SourceGeneration\Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator\BindingExtensions.g.cs(106,31,106,40): error CS9035: Required member 'MyOptionB.MyParamB' must be set in the object initializer or attribute constructor.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
    <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
    <EnableRequestDelegateGenerator>true</EnableRequestDelegateGenerator>
    <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
  </PropertyGroup>

</Project>

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

ConfigurationBinder source generator generates code that doesn't compile when using recodrs with requried properties as option Property

Reproduction Steps

build this code
`namespace BindGeneratorRepro;

using System.Reflection;

internal class Program
{
private static void Main(string[] args)
{
var builder = WebApplication.CreateSlimBuilder(args);

    builder.Services.AddOptions();

    builder.Services.AddOptions<MyOptionA>()
        .BindConfiguration("myPath", options => options.BindNonPublicProperties = true);

    var app = builder.Build();

    app.MapGet("/version", () =>
    {
        var fileVersionAttribute = Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyFileVersionAttribute>();

        return Results.Text(fileVersionAttribute!.Version);
    });

    app.Run();
}

}

internal sealed record MyOptionA
{
public required string MyParamA { get; init; }
public required MyOptionB MyParamAB { get; init; }
}

internal sealed record MyOptionB
{
public required string MyParamB { get; init; }
}`

Expected behavior

Code should compiles

Actual behavior

build files with error CS9035
BinGeneratorRepro\Microsoft.Extensions.Configuration.Binder.SourceGeneration\Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator\BindingExtensions.g.cs(106,31,106,40): error CS9035: Required member 'MyOptionB.MyParamB' must be set in the object initializer or attribute constructor.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	xmarshal
Assignees:	-
Labels:	area-Extensions-Configuration
Milestone:	-

[xmarshal]

[ThaDaVos]

Any update on this?

[ericstj]

Right now the source generator doesn't use object initializers at all, nor will it bind to init properties. This would require some significant refactoring of the generated code to support this scenario. We can consider this in a future release.

[KnapSac]

Are there plans to do some work in this area for .NET 10? Anything I can do to help?