Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] dotnet solution: Migrate #44419

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

edvilme
Copy link
Contributor

@edvilme edvilme commented Oct 23, 2024

Created dotnet solution migrate solutionfile.sln to generate a new solution file with the .slnx extension using https://github.com/microsoft/vs-solutionpersistence

Contributes to #40913 (dotnet sln migrate)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Oct 23, 2024
@edvilme edvilme changed the title [ADD] dotnet sln: Migrate [ADD] dotnet solution: Migrate Oct 23, 2024
@edvilme edvilme marked this pull request as ready for review October 23, 2024 23:09
@edvilme edvilme requested a review from a team October 23, 2024 23:09
@kasperk81
Copy link
Contributor

kasperk81 commented Oct 24, 2024

unit tests upcoming?

Addresses #40913

I thought addressing that epic also includes:

  • dotnet new solution --format slnx (with alias -f slnx)
  • dotnet sln {add,remove,list} my.slnx my.csproj commands

@edvilme
Copy link
Contributor Author

edvilme commented Oct 24, 2024

unit tests upcoming?

Hello. Yes, this is still WIP and will have a unit test that verifies if the command work. Additional testing on how the conversion is done, is more related to the https://github.com/microsoft/vs-solutionpersistence project as we just consume their API

@kasperk81
Copy link
Contributor

btw, current main and 9.0.200 branch can "build" .slnx #40913 (comment), so the test can assert on that to cover migration.

you may also consider changing Addresses #40913 to Contributes to #40913 so it doesn't close the issue on merge for additional work (dotnet new sln, dotnet sln {add,remove,list} my.slnx my.csproj), and keep this PR for dotnet sln migrate only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants