Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests on 1.95.0 and switch back to 'stable' channel #7711

Open
dibarbet opened this issue Oct 30, 2024 · 2 comments
Open

Fix integration tests on 1.95.0 and switch back to 'stable' channel #7711

dibarbet opened this issue Oct 30, 2024 · 2 comments

Comments

@dibarbet
Copy link
Member

dibarbet commented Oct 30, 2024

Switched to 1.94.2 here to fix breaks in code action tests - #7708

@dibarbet
Copy link
Member Author

dibarbet commented Oct 30, 2024

Cause appears to be microsoft/vscode#232679

Introducing an artificial 2 second delay in our code action handler causes the test to fail 100% of the time locally. CI logs show the code action request taking about ~2 seconds for the failing instances in CI as well. Passing tests have the code action request finish in under a second.

@dibarbet
Copy link
Member Author

Resolved by microsoft/vscode#232772

Once it makes it into a vscode stable release we can switch back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant