Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing even after adding reference to "System.Runtime.Serialization.Formatters" #322

Open
rchauhan18 opened this issue Jul 9, 2024 · 0 comments

Comments

@rchauhan18
Copy link
Contributor

rchauhan18 commented Jul 9, 2024

Description

The test which are using BinaryFormatter are failing with an error:
" System.Runtime.Serialization.Formatters not found " or "Data on clipboard is invalid"

This is because the BinaryFormatter is removed from dotnet and is shared as a separate Nuget package. To fix this issue we need to add reference in the csproj.

 <PackageReference Include="System.Runtime.Serialization.Formatters" Version="9.0.0-preview.7.24354.9"/> 

Issue

Even after adding the reference, the tests are still failing with the same error.
This is because in .deps.json file the reference to the nuget package is present but in the target section "runtime" path is missing.

Steps to repro

Consider test DrtSequence, it is failing with an error "Data on clipboard is invalid".
Add reference to System.Runtime.Serialization.Formatters in DrtSequence.csproj and Dependencies.csproj.
image

Also set <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization> in DrtSequence.csproj
and build the projects

Expected

The reference of System.Runtime.Serialization.Formatters should be present in DrtSequence.deps.json with the runtime path and test should pass.
image

Actual

The "runtime" path is missing for System.Runtime.Serialization.Formatters in DrtSequence.deps.json and test is failing with same error.
image

Workaound

Manually add "runtime" path in DrtSequence.deps.json file.
Add "System.Runtime.Serialization.Formatters.dll" to the same path.

Paths:
DrtSequence.deps.json "\wpf-test\publish\Debug\x64\Test\DRT"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant