Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added php-fpm_exporter binary and entrypoint script #316

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Added php-fpm_exporter binary and entrypoint script #316

merged 2 commits into from
Oct 1, 2024

Conversation

nicksantamaria
Copy link
Contributor

@nicksantamaria nicksantamaria commented Oct 1, 2024 •
edited
Loading

Motivation

We would like to better understand our PHP applications performance characteristics.

Changes

  • Adds the php-fpm_exporter binary to the php-fpm
  • Adds a entrypoint script to the php-fpm image which conditionally starts the php-fpm_metrics binary

Usage

  • Set PHP_FPM_EXPORTER_ENABLED=trueto run the metrics exporter
  • Metrics data should be available at container-ip:9253/metrics

@nicksantamaria
Copy link
Contributor Author

/build

1 similar comment
@nicksantamaria
Copy link
Contributor Author

/build

@nicksantamaria nicksantamaria requested review from steveworley and GROwen and removed request for steveworley October 1, 2024 06:19
@nicksantamaria
Copy link
Contributor Author

I've tested this out on the go-vic API app. Works well, no sidecars required.

@nicksantamaria nicksantamaria mentioned this pull request Oct 1, 2024
Merged
@steveworley
Copy link
Contributor

Oooh that's awesome! It doesn't need a side car. That's pretty nifty.

@nicksantamaria nicksantamaria merged commit 77ec740 into 6.x Oct 1, 2024
1 check passed
@nicksantamaria nicksantamaria deleted the feature/php-fpm-exporter branch October 1, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveworley steveworley steveworley approved these changes

@GROwen GROwen Awaiting requested review from GROwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicksantamaria @steveworley