Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Primary Nav, Nav Bar Action items vertically #1112

Open
2 of 4 tasks
eschweitzer78 opened this issue Apr 12, 2024 · 0 comments
Open
2 of 4 tasks

Align Primary Nav, Nav Bar Action items vertically #1112

eschweitzer78 opened this issue Apr 12, 2024 · 0 comments
Assignees
Labels
Proposal - Draft New feature proposal

Comments

@eschweitzer78
Copy link

eschweitzer78 commented Apr 12, 2024

Describe the feature

Align nav bar action items vertically in a primary nav.

Check current state ->
Public Storybook for Primary Nav

Motivation

Aligned items are more aesthetically pleasing IMHO.

Proposal

Thanks for all the great work you do!

Nav Bar action items that are of toggle type are not perfectly aligned with those of link type (off by 1px both on Chrome and Safari):

image

Adjusting the display of .rpl-primary-nav__nav-bar-action>div to flex seems to solve it (and places the chevron on the right hand side of the two-line action):

image

Perhaps this is an adjustment you could consider?

Misaligned chevron down icons are not eye-pleasing either - I'd prefer everything aligned on a baseline, but that would be a more substantial change...

Benefits

Alignment is aesthetically pleasing.

Drawbacks

Introduces a change in appearance.

Adoption strategy

No adoption strategy required.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be created outside of Ripple-framework as a layer?

Final checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal - Draft New feature proposal
Projects
None yet
Development

No branches or pull requests

2 participants