Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

EventType::getIdentityTypeEntityFormMode() should return a form mode string #152

Open
MegaChriz opened this issue Sep 29, 2017 · 1 comment

Comments

@MegaChriz
Copy link

On the event type form, when you select an alternative form mode for a person, it looks like the change is not saved, because when the form is reloaded the default form mode seems to be selected.

I have found that the bug is in EventType::getIdentityTypeEntityFormMode(). This returns a boolean, while it should return a string representing the selected form mode, according to EntityTypeInterface::getIdentityTypeEntityFormMode().

Pull request will follow.

MegaChriz added a commit to MegaChriz/rng that referenced this issue Sep 29, 2017
@MegaChriz
Copy link
Author

I'm not so familiar with pull requests yet. On drupal.org I was used to create the issue first, then submit a patch. Apparently, it works a bit different on Github.

So should this be closed as a duplicate now of #153?

MegaChriz added a commit to MegaChriz/rng that referenced this issue Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant