Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to remove origin from fields #9

Open
sd2k opened this issue Oct 28, 2024 · 2 comments
Open

Add flag to remove origin from fields #9

sd2k opened this issue Oct 28, 2024 · 2 comments

Comments

@sd2k
Copy link

sd2k commented Oct 28, 2024

Hey, thanks for creating this fork and maintaining it. I was wondering how you'd feel about also merging this PR in to avoid the origin field with filename/line number being added? There's some justification in the original issue.

(Maybe there's a more nuanced solution like allowing the user to filter the fields somehow, not sure what you'd prefer!)

@dsgallups
Copy link
Owner

Sounds great! I'll see about shipping that later this evening.

@dsgallups
Copy link
Owner

dsgallups commented Oct 28, 2024

What I'll do is merge in the PR first for a release. Need to update changelog and push CI for playwright testing, and then can see about filtering the fields afterwards.

Update: I'll need a few more days, would love to get some CI going. The old tests didn't do anything but validate a redundant builder pattern...wip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants