Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passwords being logged and shown in the clear #192

Open
krcb197 opened this issue Apr 26, 2023 · 4 comments
Open

passwords being logged and shown in the clear #192

krcb197 opened this issue Apr 26, 2023 · 4 comments

Comments

@krcb197
Copy link

krcb197 commented Apr 26, 2023

It is possible to run the module by passing in a user name and password, for example:

svn_report = svn.remote.RemoteClient(svn_item, username=user_name, password=mypassword_as_a_string )
svn_report.export(target_dir)

Even if you have followed all the good practices for handling passwords within your code, the svn package has two issues:

  • in the CommonBase the full svn command is sent to the debug log
  • In the event of failure full command is sent to the exception, which then shows in many places

The password should be obscured before the errors or logs are made

@krcb197
Copy link
Author

krcb197 commented Apr 28, 2023

This ticket is a partial duplicate of #125

@krcb197
Copy link
Author

krcb197 commented Apr 28, 2023

I have submitted a Pull Request with a fix in it. Hopefully it will be accepted.

@rjfs
Copy link

rjfs commented Jun 28, 2023

Any plans for accepting the PR? I must admit I don't feel safe using the package with this problem on it.

@krcb197
Copy link
Author

krcb197 commented Jun 28, 2023

This issue only affects the case where the credentials are being passed through Python. In many case there are other ways to avoid the issue:

  • including letting the SVN executable cache the credentials
  • passing them through an environment variable.

That said I am not sure who we need to lobby/persuade to get the updates through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants