You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The split assumes that all the images corresponding to the albums are present in the same resource
Also assumes that the albums that images belong in are also in the same resource (which they may not be if the album was created in the prior resource).
I found this while trying to port this code to the media container resource and incorporate videos, in the meantime im going to not port this over since we have our own handling of this on the Google end and i don't think anyone else relies on this.
The text was updated successfully, but these errors were encountered:
backfills missing unit tests of MedaiContainerResourceTest and fixes a bug in the process
This change forks test code (`{Photos,Media}ContainerResourceTest`) in line with MediaContainerResource's existing creation, then deletes some transmogrification stuff that we're not doing (per issue #1000) and adds a TODO(#1060) atop the new test to finish the tests more fully for video logic.
The
ensureAlbumSize
function in the PhotosContainerResource doesn't look entirely correcthttps://github.com/google/data-transfer-project/blob/master/portability-types-common/src/main/java/org/datatransferproject/types/common/models/photos/PhotosContainerResource.java#L102-L139
A couple of notable things:
I found this while trying to port this code to the media container resource and incorporate videos, in the meantime im going to not port this over since we have our own handling of this on the Google end and i don't think anyone else relies on this.
The text was updated successfully, but these errors were encountered: