Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransmogrificationConfig for Google importers #1144

Open
incjo opened this issue Aug 17, 2022 · 3 comments
Open

Add TransmogrificationConfig for Google importers #1144

incjo opened this issue Aug 17, 2022 · 3 comments

Comments

@incjo
Copy link
Contributor

incjo commented Aug 17, 2022

Currently, transmogrification logic is being duplicated in the Google adapter code. Add a TransmogrificationConfig to fix this.

@sreenath-tm
Copy link

I'm interested in contributing to this issue, so before I start working it, would anyone mind sparing a little time explaining what the issue is about and pointing me to some resources to get started.

@incjo
Copy link
Contributor Author

incjo commented Sep 5, 2022

When dealing with the album, photo and video names and descriptions, Google adapters manually sanitise the strings. Instead, it's meant to be dealt by implementing a Google specific TransmogrificationConfig. It should be fairly straightforward. Look at how other such configs are used, do something similar and remove explicit name truncation from the adapter code.

@lisad
Copy link
Member

lisad commented Oct 28, 2024

Noting that we reviewed this in October of 2024, and it's dependent on backlogged work in Google photos team so we will just leave this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants