Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete a link with an asterisk in the path #1324

Open
wdhdev opened this issue Oct 5, 2024 · 5 comments
Open

Cannot delete a link with an asterisk in the path #1324

wdhdev opened this issue Oct 5, 2024 · 5 comments

Comments

@wdhdev
Copy link
Contributor

wdhdev commented Oct 5, 2024

If you create a short link with * in the slug, when attempting to delete it, the input validation says it is not valid:

image

It seems to be an issue with the pattern HTML attribute on the input field.

Browser: Firefox 131.0

Copy link

linear bot commented Oct 5, 2024

@sudipb7
Copy link

sudipb7 commented Oct 7, 2024

I tested it. If you create a short link with * in the slug, for example, hrsn.link/* you'll have to type hrsn.link to validate the input.

@wdhdev
Copy link
Contributor Author

wdhdev commented Oct 7, 2024

Yep, that works, however it is still technically a validation issue that probably should be fixed. Either by disallowing the * character when creating links, or by just somehow fixing the frontend validation for deleting a link with the * character in it.

@sudipb7
Copy link

sudipb7 commented Oct 7, 2024

I guess both are needed as there can be existing links with * and user should not be able to create links like this

@steven-tey steven-tey changed the title Incorrect input validation on confirm delete Cannot delete a link with an asterisk in the path Oct 12, 2024
@ShashankGupta10
Copy link

Can i work on this @steven-tey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants