Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Breaks on Add New API Key Drawer with Restricted Permissions on Mobile #1609

Open
unrenamed opened this issue Oct 22, 2024 · 10 comments · May be fixed by #1612 or #1620
Open

UI Breaks on Add New API Key Drawer with Restricted Permissions on Mobile #1609

unrenamed opened this issue Oct 22, 2024 · 10 comments · May be fixed by #1612 or #1620
Assignees
@unrenamed
Labels
🕹️ oss.gg 🕹️ 750 points

Comments

@unrenamed
Copy link
Contributor

Issue Summary

When accessing the Settings > API Keys page on mobile, opening the Add new API Key drawer and selecting the Restricted permissions option causes UI issues. The Create API key button becomes unclickable, and the animated list of restricted permissions appears incomplete, as it is cut off at the bottom. This issue prevents users from completing the process of adding a new API key with restricted permissions.

Steps to Reproduce

  1. Open the application on a mobile device.
  2. Navigate to Settings > API Keys.
  3. Click on the Create button to open the drawer.
  4. Select the Restricted permissions option from the available options.
  5. Try to scroll through the animated list of restricted permissions.

Expected behavior

  1. The UI should display the full list of restricted permissions without being cut off at the bottom.
  2. The Create API Key button should remain clickable and functional, allowing the user to proceed with adding a new API key.

Screenshots/Videos

Screen.Recording.2024-10-22.at.18.08.41.mov

Version info

Tested on both:

  1. iPhone 8+ iOS 16.7.10
  2. Brave 1.71.114 Chromium: 130.0.6723.58 (Official Build) (arm64)

The video was recorded using Brave browser. The issue is the same on iOS, although looks just a bit different (the scroll does not work at all, i.e. there is no empty white space at the bottom)
@linear Linear
Copy link

linear bot commented Oct 22, 2024

ENG-860 UI Breaks on `Add New API Key` Drawer with `Restricted` Permissions on Mobile

@steven-tey
Copy link
Collaborator

steven-tey commented Oct 22, 2024 •
edited
Loading

Good find! I have assigned the issue to you @unrenamed, feel free to PR!

@aritradevelops
Copy link
Contributor

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 22, 2024

This issue is already assigned to another person. Please find more issues here.

@aritradevelops aritradevelops linked a pull request Oct 22, 2024 that will close this issue
Open
@aritradevelops
Copy link
Contributor

@steven-tey please have a look at my PR and suggest if any further changes is needed! Thanks!

@unrenamed
Copy link
Contributor Author

unrenamed commented Oct 22, 2024 •
edited
Loading

@aritradevelops I see you've submitted a PR for this bug. However, this bug was assigned to me, and I'm actively working on a fix. According to the oss.gg event guidelines, I still have 48 hours to submit my PR. In the future, it would be great to respect assignments and give others the opportunity to complete their tasks.

@aritradevelops
Copy link
Contributor

aritradevelops commented Oct 23, 2024 •
edited
Loading

Hey @unrenamed I'm really sorry 🙏🏽, I was unaware that oss.gg guidelines does not allow PR for assigned open issues.I thought it's a competition so whoever finds the solution first can raise a PR. I just found a working solution within couple of hours therefore I have raised a PR for the same. So I will wait for your 48 hours to end if you find a better solution please proceed. I have no issues. We're both trying to win here, this often happen in case of bug bounties, it's not like I'm not respecting your assignment. None the less sorry again, Pal.

@steven-tey
Copy link
Collaborator

Appreciate your PR @aritradevelops but yes, this issue was assigned to @unrenamed so I'll default to him to create a PR within 48 hours before reviewing other submissions 🙏

@unrenamed unrenamed linked a pull request Oct 23, 2024 that will close this issue
Open
@Kartikey1306
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 23, 2024

This issue is already assigned to another person. Please find more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unrenamed unrenamed

Labels
🕹️ oss.gg 🕹️ 750 points
Projects
None yet
Milestone
No milestone
4 participants
@steven-tey @unrenamed @aritradevelops @Kartikey1306