From c5e7969df871a84f626bf5994b68b330ef0e22d6 Mon Sep 17 00:00:00 2001 From: Elle Sullivan Date: Wed, 29 May 2024 12:41:15 +0100 Subject: [PATCH 1/2] Remove autofill survey (#2819) Task/Issue URL: https://app.asana.com/0/1187352151074490/1207364165261200/f Tech Design URL: CC: **Description**: Remove the autofill survey but not all associated code (e.g. the persisted flag), since I have zero context there. **Steps to test this PR**: 1. On main, go to Settings > Passwords and confirm the survey prompt is visible 2. Do likewise on this branch and confirm it isn't. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --- .../View/PreferencesAutofillView.swift | 36 ------------------- 1 file changed, 36 deletions(-) diff --git a/DuckDuckGo/Preferences/View/PreferencesAutofillView.swift b/DuckDuckGo/Preferences/View/PreferencesAutofillView.swift index 77fe6bec54..6cf2b84b6f 100644 --- a/DuckDuckGo/Preferences/View/PreferencesAutofillView.swift +++ b/DuckDuckGo/Preferences/View/PreferencesAutofillView.swift @@ -68,42 +68,6 @@ extension Preferences { // Autofill Content Button PreferencePaneSection { - // New section - if model.autofillSurveyEnabled { - HStack(alignment: .top, spacing: 20) { - Image(.passwordsDDG128) - .frame(width: 64, height: 48) - - VStack(alignment: .leading) { - Text(verbatim: "Help us improve!") - .bold() - Text(verbatim: "We want to make using passwords in DuckDuckGo better.") - .foregroundColor(.greyText) - .padding(.top, 1) - - HStack { - Button(action: { - model.disableAutofillSurvey() - }, label: { - Text(verbatim: "No Thanks") - }) - Button(action: { - model.launchSurvey() - }, label: { - Text(verbatim: "Take Survey") - }) - .buttonStyle(DefaultActionButtonStyle(enabled: true)) - } - .padding(.top, 12) - } - - Spacer() - } - .padding() - .roundedBorder() - .padding(.bottom, 24) - } - Button(UserText.autofillViewContentButton) { model.showAutofillPopover() } From a1692ff305170819ead0aa1739f2bc2c541ae477 Mon Sep 17 00:00:00 2001 From: Dax the Duck Date: Thu, 30 May 2024 08:38:40 +0000 Subject: [PATCH 2/2] Bump version to 1.90.0 (193) --- Configuration/BuildNumber.xcconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Configuration/BuildNumber.xcconfig b/Configuration/BuildNumber.xcconfig index ffacba59c9..f3433420ac 100644 --- a/Configuration/BuildNumber.xcconfig +++ b/Configuration/BuildNumber.xcconfig @@ -1 +1 @@ -CURRENT_PROJECT_VERSION = 192 +CURRENT_PROJECT_VERSION = 193