Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Reject feedback requests without rating #13

Open
sippsack opened this issue Oct 25, 2018 · 2 comments
Open

Reject feedback requests without rating #13

sippsack opened this issue Oct 25, 2018 · 2 comments

Comments

@sippsack
Copy link
Contributor

sippsack commented Oct 25, 2018

Currently you can send a feedback without rating and comment. The comment is optional, it is just empty. But the rating is saved as 0 (zero). We have two options:

  1. rating is mandatory and comment is optional
  2. at least one of them has to been set (rating and/or comment). this allows to give a comment without influence the average rating.
    (3.) current state, both are optional: then we need to filter the zero ratings in the feedback results

The frontend should validate accordingly, if we decide for 1. or 2.

Another idea: make it configurable if rating is mandatory. So the client can validate corresponding to the config.

@srose
Copy link
Contributor

srose commented Jan 29, 2019

Decision?

@sippsack
Copy link
Contributor Author

not yet. we should discuss it at JavaLand

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants