Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max datapoints default param #55

Open
andrewhong5297 opened this issue Jun 3, 2023 · 8 comments
Open

max datapoints default param #55

andrewhong5297 opened this issue Jun 3, 2023 · 8 comments

Comments

@andrewhong5297
Copy link
Contributor

For new teams and users, we've instituted a max datapoints of 250,000 as default so that they don't spend too many credits on accident. This is configurable in their Dune settings, but you can also ignore this maximum using the parameter ignore_max_datapoints_per_request = True.

Just adding it as an issue here as an FYI when the team has time to add this in!

@bh2smith
Copy link
Collaborator

bh2smith commented Jun 4, 2023

So I see a few somewhat informal things about data points and how they are calculated here in API pricing. This then leads me to look here

where I am seeing

curl -X GET "https://api.dune.com/api/v1/execution/{{execution_id}}/results/?ignore_max_datapoints_per_request/=true" -H x-dune-api-key:{{api_key}}'

namely

ignore_max_datapoints_per_request/=true

Is there really a random slash at the end?

I tried this for 01GZE567WK578FP9E9EGKEKQQE and got this weird thing back:

<a href="/api/v1/execution/01GZE567WK578FP9E9EGKEKQQE/results?ignore_max_datapoints_per_request/=true">Moved Permanently</a>.

This appears to mean that the dataset is too old and can not longer be recovered... actually it appears to mean that query execution failed.

  • it appears the random slash can be included or excluded here and it doesn't make a difference.
  • there are some typos in the curl strings (like one to few single quotes on the headers.
  • It would be a lot more convenient if the curl commands used actual bash notation like ${DUNE_API_KEY} instead of dune query parameter notation {{api_key}}

I will create issues in the relevant repo.

@msf
Copy link
Collaborator

msf commented Jun 4, 2023 via email

@bh2smith
Copy link
Collaborator

bh2smith commented Jun 4, 2023

Also, I am pretty sure this endpoint does not exist:

$ export JOB_ID=01H22T5ZYMWVCAWJP8DTX3NXE2                       
$ curl -X GET "https://api.dune.com/api/v1/execution/${JOB_ID}/results/?ignore_max_datapoints_per_request=true" -H x-dune-api-key:${DUNE_API_KEY}
<a href="/api/v1/execution/01H22T5ZYMWVCAWJP8DTX3NXE2/results?ignore_max_datapoints_per_request=true">Moved Permanently</a>.

@msf
Copy link
Collaborator

msf commented Jun 4, 2023 via email

@bh2smith
Copy link
Collaborator

bh2smith commented Jun 4, 2023

whats the doc page that has this?

Here I made a PR:

duneanalytics/docs#333 (comment)

@andrewhong5297
Copy link
Contributor Author

ah my bad, just copied and pasted what I was given in some other ticket - thanks for fixing

@bh2smith
Copy link
Collaborator

bh2smith commented Jun 6, 2023

Still not sure if the endpoint actually works though...

@msf
Copy link
Collaborator

msf commented Jun 7, 2023

the docs are still buggy, you still have an extra trailing slash on
/.../results/?ignore_max...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants