Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Branch constructor consistent with other composite runnables #208

Open
randomir opened this issue Oct 3, 2019 · 0 comments
Open

Make Branch constructor consistent with other composite runnables #208

randomir opened this issue Oct 3, 2019 · 0 comments
Labels
breaks compatibility Proposal breaks backwards compatibility

Comments

@randomir
Copy link
Member

randomir commented Oct 3, 2019

While other composing runnables take children runnables as positional arguments (children-accepting: Branches, Parallel, Race; child-accepting: Loop, Map, Unwind), Branch takes its children in a single argument, components.

Although there are benefits of this approach (lazy composition/iteration, explicitness), and Branch constructor is rarely used explicitly (usually implicitly with | operator), the inconsistency can be confusing for users (see #207).

@randomir randomir added the breaks compatibility Proposal breaks backwards compatibility label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks compatibility Proposal breaks backwards compatibility
Projects
None yet
Development

No branches or pull requests

1 participant