Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip must not have both prefix and suffix actions #1873

Open
raquelarrojo opened this issue Mar 8, 2024 · 4 comments · Fixed by #1943
Open

Chip must not have both prefix and suffix actions #1873

raquelarrojo opened this issue Mar 8, 2024 · 4 comments · Fixed by #1943
Assignees
@raquelarrojo
Labels
enhancement New feature or request jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.

Comments

@raquelarrojo
Copy link
Collaborator

raquelarrojo commented Mar 8, 2024 •
edited
Loading

Describe the solution you'd like
The chip can only have one action.
It can have 2 icons if one of them has an action, if not, both icons are not allowed.

This decision has been taken after a design investigation.
@raquelarrojo raquelarrojo added enhancement New feature or request jira This task is referenced in a story of Jira labels Mar 8, 2024
@raquelarrojo raquelarrojo self-assigned this Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Thank you for opening an issue! 🚀

Our team will review it as soon as possible. In the meantime, please make sure that you've provided all the necessary details to help us understand and address the issue effectively.

Feel free to contribute and participate in discussions!

@raquelarrojo raquelarrojo changed the title Chip must not have both prefix and suffix icons Chip must not have both prefix and suffix actions Mar 12, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Mar 28, 2024
@Mil4n0r Mil4n0r removed the stale This task has no activity and will be closed within 15 days. label Apr 2, 2024
@Mil4n0r Mil4n0r mentioned this issue Apr 2, 2024
Open
@raquelarrojo raquelarrojo mentioned this issue Apr 10, 2024
Merged
5 tasks
@raquelarrojo raquelarrojo reopened this Apr 18, 2024
@raquelarrojo
Copy link
Collaborator Author

Fix available here:
https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-fixes
https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-specs

It has been reverted to avoid creating a breaking change.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label May 4, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raquelarrojo raquelarrojo

Labels
enhancement New feature or request jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several fixes in the Chip dxc-technology/halstack-react
2 participants
@raquelarrojo @Mil4n0r