Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util][netutil] Port wait from it from benchhub #122

Open
at15 opened this issue Jan 22, 2020 · 1 comment
Open

[util][netutil] Port wait from it from benchhub #122

at15 opened this issue Jan 22, 2020 · 1 comment

Comments

@at15
Copy link
Member

at15 commented Jan 22, 2020

While cleaning up benchhub (got too many chores ..) found the wait for it package that is often used to wait for a tcp/http port to be ready. It is useful for one time benchmark, not that useful for actual database connection because you need to retry and backoff etc.

Also a waitforit binary and docker image can be useful. The waitforit should use static link so it can run using busybox/scratch container

@at15 at15 added this to the 0.0.14 milestone Jan 22, 2020
@at15
Copy link
Member Author

at15 commented Feb 11, 2020

The original code is at https://github.com/benchhub/benchhub/tree/master/_legacy/lib/waitforit

Also found a interesting one in dyweb/go.ice#56 https://github.com/testcontainers/testcontainers-go/tree/master/wait

Might have a dedicated wait package and have gommon wait and a dedicated cmd/waitforit (or maybe waitonme to reduce binary size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant