-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the "default" label options #1085
Comments
Agreed. I will also remove Speaking of cleaning up label options, we need a strategy to migrate the the label options of active deployments.
For example I think that at least with
|
@JGreenlee wrt
we may want to change the dynamic config download to be auto instead of manual so that people in those programs will have the new config, even if the program is long-running. Ideally, we would have the auto vs. manual be a config option itself, to also support other community-based apps that want to ensure that surveys are not changed in the middle of the data collection, but I would suggest that should be an option in config.xml (at the app level) so that we don't have the "auto-update config" flag be part of the config. In which case, we should deal with it as part of #850 (comment) |
In unifying the base mode colors #143, we've encountered the fact that the "default" label options are stored in a few different places.
em-common
seems like a good place to keep them, so that the phone and dashboard can both rely on the same dependency. While we're making this change, we can also remove the old csv files, and remove the example json files fromnrel-openpath-deploy-configs
to keep the defaults all in one place.The basic goal we need to reach is:
We already handle "(ii) platform specified custom modes" - that is what our dynamic labels are
We need to centralize "(i) platform specified default modes" - it is seeming that the best way to do this will be to rely on a central file in
emcommon
label-options.default.json instead of the csvs we currently use. We can also use this as the basis for the examples that we show deployers, and remove the other example files fromnrel-openpath-deploy-configs
.Currently, (iii) user specified modes get displayed on the dashboard as "Other"
The text was updated successfully, but these errors were encountered: