Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts are not generated for Average Trips Length (selected by users) and Average Trip Length (sensed) metrics #107

Open
iantei opened this issue Dec 19, 2023 · 0 comments

Comments

@iantei
Copy link
Contributor

iantei commented Dec 19, 2023

Both Average Trips Length (selected by users) and Average Trip Length (sensed) are not generated in the production environment for public dashboard associated with https://ebikegj-openpath.nrel.gov/public/
Also, replicable in below:
https://openpath-stage.nrel.gov/public/

image

The above two metrics i.e. "Average Trips Length (selected by users)" and "Average trip length (sensed)" are represented by average_miles_mode_confirm2 and average_miles_sensed_mode respectively in metrics_study/program.html.
All other metrics generated are associated with their respective values in notebook to generate static charts.
With both of these metrics, there are no associated code available in notebook to generate the required static charts.

Investigation details:

  1. For Average Trip Length (selected by users):

The generation of chart associated with "Average Trip Length (selected by users)" have been removed in the commit #51 . Further, I do not see any file_name associated with average_miles_mode_confirm2 in the current main branch.

image

Possible solution:
There's barplot_mode2() present on plots.py. We could revert back this change, and make call for this function from generic_metrics.ipynb notebook and it should work.

  1. For Average Trip Length (sensed):

There are no required changes which would generate the file average_miles_sensed_mode in generic_metrics_sensed.ipynb notebook, while all other sensed related metric chart files are being generated properly here. #92

Possible solution:
We will need to incorporate changes for the average_miles_sensed_mode in the generic_metrics_sensed.ipynb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant