-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues in staging public dashboard #160
Comments
I am not sure what you mean by this "issue". If it is imperial, we use miles. If it is metric, we use km. That is as expected. |
If you look into the chart for
|
Ah thank you for the clarification. We discussed this back when you were working on your first PR. If you pass in a GET parameter to the website, it is not and will not be passed to the notebooks. So this is expected behavior. |
Yes, I remember that now. |
There is an issue #160 (comment) with the current production public dashboard, which I was also able to observe in my local system. The issue is that it uses "Miles" as the hardcoded value instead of choosing between Kilometer/Miles based on the use_imperial. |
@shankari There are a few issues observed in the staging of public dashboard. Issue 1 and 2 have been fixed, and published as PR. I am not sure how to further debug and understand for Issue 3.
[Fixed] Use of
expanded_ct_inferred
instead ofexpanded_ct_inferred_u80
to showcase labeled and inferred bar for trips under 80%. Fix the inferred_u80 inferred label bar #159 30635f7[Fixed] Extra information in the plot_title for Replaced modes
Patch fixes: Eliminate plot_title for Replaced mode stacked bar charts #157 6833854
imperial
vsmetric
measurement system in plot title and possibly calculation in staging and current main PR. Why is it showing up as "kilometer - kilogram" instead of "miles - lbs" in staging?use_imperial = "True"
like uue which is study-use_imperial, while also observed with ca-ebike and durham which is program-use_imperialDetailed Diff of docker-compose.yml:
Looks fine in local testing - Main PR.
Note: The issue with Labeled and Labeled and Inferred for ca-ebike is fixed here #155
Could you please help me understand what could possibly be going wrong on [Issue : 3]?
The text was updated successfully, but these errors were encountered: