Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brainstorming] What should the "Full Viz" button do during protocol step visualization? #20

Open
Ayurshi opened this issue Aug 9, 2019 · 3 comments
Labels
brainstorming Brainstorming for future features/changes enhancement New feature or request

Comments

@Ayurshi
Copy link

Ayurshi commented Aug 9, 2019

For now, it would be best to keep it inactive during protocol step visualization (greyed out).

Although different visualization variations can be considered and discussed upon for instance:
For FWD/BWD inactive full viz shows only the trg /src respectively. Or only to be translated or to be created elements. Similarly for modelgen different ideas can be discussed.

@Ayurshi Ayurshi changed the title [Brainstorming] What should the "Full Viz" button do during protocol step visualization ? [Brainstorming] What should the "Full Viz" button do during protocol step visualization? Aug 9, 2019
@anthonyanjorin
Copy link
Collaborator

My opinion on this: for a selection of a single protocol step, the full vis could show the corresponding rule and how it was applied (fairly analogous to the normal full vis for matches).

What I can't say (and I suggest we just disable the button), is what should happen when multiple steps are selected :) While we could display all rules and show how they are applied (potentially multiple times), I think this will just be a pretty chaotic diagram.

Any other thoughts on this?

@LegionaryCohort
Copy link

Coming from an interface-design perspective:
Having one button or option that does multiple different things depending on context is potentially very confusing for the user.
I would suggest that this kind of functionality be split into multiple options that only act on very specific contexts (e.g. options for rule vis, match vis and protocol vis seperately). Only those options that have the same behaviour in all areas should be universal options.

@anthonyanjorin
Copy link
Collaborator

anthonyanjorin commented Aug 9, 2019

Define "same behaviour" :) I could argue that full vis should simply toggle between a kind of minimal and complete version of the current diagram. If we can define these versions for different diagrams then the button should be fairly natural for the user.

Want to see more details? Push the button (of course we shouldn't start rotating the diagram or changing colours).

There should be an issue (#181), however, on generalising the full vis button to a dropdown with multiple options for how to display and filter the current diagram. If we transition to this then yes, we could just add extra entries in the dropdown menu depending on the context and with very specific names.

@anthonyanjorin anthonyanjorin transferred this issue from eMoflon/emoflon-ibex-ui Aug 15, 2019
@LegionaryCohort LegionaryCohort added the brainstorming Brainstorming for future features/changes label Aug 16, 2019
@anthonyanjorin anthonyanjorin added the enhancement New feature or request label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming Brainstorming for future features/changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants