You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This discussion's intent is to define a better approach from symbols' visibility. It has sprouted from #88 and #89 by @roehling.
Important points to clarify would be:
Fix the problem of exporting the library exception classes, which right now are not exported per se, but in a member function by member function basis instead, since they inherit from std::exception which is not exported.
For this case, Fix visibility of exception classes #88 proposed simply disabling the MSVC warnings, but does not seem like a solution to the problem either, so it was discarded.
Whether to set the -fvisibility=hidden and -fvisibility-inlines-hidden flags in GCC so that only the specified symbols are exported (similar to MSVC approach)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This discussion's intent is to define a better approach from symbols' visibility. It has sprouted from #88 and #89 by @roehling.
Important points to clarify would be:
std::exception
which is not exported.For this case, Fix visibility of exception classes #88 proposed simply disabling the MSVC warnings, but does not seem like a solution to the problem either, so it was discarded.
-fvisibility=hidden
and-fvisibility-inlines-hidden
flags in GCC so that only the specified symbols are exported (similar to MSVC approach)Beta Was this translation helpful? Give feedback.
All reactions