Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Is exist_confxml_from_template production ready? #52

Open
adamretter opened this issue Apr 19, 2023 · 2 comments
Open

[bug] Is exist_confxml_from_template production ready? #52

adamretter opened this issue Apr 19, 2023 · 2 comments

Comments

@adamretter
Copy link
Contributor

adamretter commented Apr 19, 2023

The README.md for this project states:

exist_confxml_from_template: no

Whether to create certain config files from templates. Not fully supported for conf.xml and web.xml, leave that disabled!

Additionally the defaults/main.yml file states:

# XXX these are not fully supported yet, leave as is!
exist_confxml_from_template: no

However, it appears that this option has been set to yes in certain production systems that we have inherited. So I am wondering of the documentation is out of date, or that this should not actually be used in a production system?

Additionally if I search through this Ansible code, it appears to me that all exist_confxml_* settings will actually be ignored unless exist_confxml_from_template: yes is set. Is that the case?

@adamretter adamretter changed the title Is exist_confxml_from_template production ready? [bug] Is exist_confxml_from_template production ready? Apr 19, 2023
@chakl
Copy link
Collaborator

chakl commented Apr 19, 2023

Means "leave this disabled unless you know what you are doing"

all exist_confxml_* settings will actually be ignored unless exist_confxml_from_template: yes is set.

yes

@adamretter
Copy link
Contributor Author

So the documentation is incorrect. I will send a Pull Request to fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants