Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUT to update for experiments should not use actions in payload #69

Open
bhufmann opened this issue Dec 9, 2021 · 3 comments · May be fixed by #70
Open

PUT to update for experiments should not use actions in payload #69

bhufmann opened this issue Dec 9, 2021 · 3 comments · May be fixed by #70
Labels
bug

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Dec 9, 2021

PUT for experiments command should not use actions in payload (see below). To add or remove traces provide a list of traces UUIDs in the payload and the server needs to validate whether traces need to be added or removed from the experiment by comparing the lists of traces on the server and in the command

image
@bhufmann bhufmann added the bug label Dec 9, 2021
@bhufmann bhufmann mentioned this issue Dec 9, 2021
Open
bhufmann added a commit to bhufmann/trace-server-protocol that referenced this issue Dec 9, 2021
@bhufmann
Change PUT experiment specification to update experiments
a199b1e 
- Rename operation "putExperiment" to "updateExperiment"
- Remove actions to remove or add traces
- Move name query parameter to payload

fixes eclipse-cdt-cloud#69

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann linked a pull request Dec 9, 2021 that will close this issue
Draft
@bhufmann
Copy link
Collaborator Author

related discussion: eclipse-cdt-cloud/theia-trace-extension#608

@bhufmann
Copy link
Collaborator Author

Way forward is defined in this ADR: eclipse-cdt-cloud/theia-trace-extension#688

@bhufmann
Copy link
Collaborator Author

bhufmann commented Nov 2, 2023

#96 proposes a different way to provide actions to the TSP. Adding/removing traces or renaming should be done in a similar way. These actions changing the resource in a way that a new resource is created:

POST /tsp/api/experiments/{expUUID}:add
POST /tsp/api/experiments/{expUUID}:remove
POST /tsp/api/experiments/{expUUID}:rename

Note that ADR eclipse-cdt-cloud/theia-trace-extension#688 needs to be updated for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change PUT experiment specification to update experiments bhufmann/trace-server-protocol
1 participant
@bhufmann