Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package name for .dsl editor is limited to "org.eclipse.gemoc" and dsl.xtext plugins not correctly named #173

Open
dvojtise opened this issue Jun 10, 2020 · 1 comment
Open

Package name for .dsl editor is limited to "org.eclipse.gemoc" and dsl.xtext plugins not correctly named #173

dvojtise opened this issue Jun 10, 2020 · 1 comment
Labels
refactoring

Comments

@dvojtise
Copy link
Contributor

All java package names of the .dsl editor have only org.eclipse.gemoc as base instead of org.eclipse.gemoc.dsl

This is not precise enough. All these packages must be renamed to use their plugin name as base name.

(note, this was probably due to the original creation using xtext wizard, the refactoring must take care of aslo updating the mwe2 generator file)
@dvojtise
Copy link
Contributor Author

Additionnaly, I suggest to rename the following plugins:

  • org.eclipse.gemoc.dsl → org.eclipse.gemoc.dsl.xtext
  • org.eclipse.gemoc.dsl.ide → org.eclipse.gemoc.dsl.xtext.ide
  • org.eclipse.gemoc.dsl.ui → org.eclipse.gemoc.dsl.xtext.ui

The only correctly named plugin is org.eclipse.gemoc.dsl.model

@dvojtise dvojtise changed the title Package name for .dsl editor is limited to "org.eclipse.gemoc" Package name for .dsl editor is limited to "org.eclipse.gemoc" and dsl.xtext plugins not correctly named Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvojtise