GLSPCommandStack: Failed to execute command: TypeError: Cannot read property 'some' of undefined

[rsoika]

Hi,
I run into a strange problem, which I can not narrow down.
After extending my initial MinimalExample with more and more features from the Workflow Example code, I get now the runtime error message below each time when I click on a element or I try to add a new element from the palette into the diagram.

I extended the GModelJsonDiagramModule by overwriting more and more methods like configureActionHandlers or configureContextActionsProviders as I thought some important/expected functionality is missing... but the problem still exists.

From the error message I guess it is something with the functionality of Edges. Can someone give me a hint what the error message below tries to tell me, or which part of my GLSP Server causes the issue?

root ERROR 10:50:38 PM minimal-diagram_0 GLSPCommandStack: Failed to execute command: TypeError: Cannot read property 'some' of undefined
    at http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:3551:59
    at Array.filter (<anonymous>)
    at TypeHintProvider.getValidEdgeElementTypes (http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:3551:18)
    at ApplyTypeHintsCommand.applyShapeTypeHint (http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:3496:60)
    at http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:3469:22
    at FluentIterableImpl.forEach (http://localhost:3000/vendors-node_modules_sprotty-theia_lib_theia_diagram-module_js.bundle.js:22891:17)
    at ApplyTypeHintsCommand.execute (http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:3467:34)
    at http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:1617:57
    at Array.forEach (<anonymous>)
    at FeedbackAwareUpdateModelCommand.performUpdate (http://localhost:3000/vendors-node_modules_eclipse-glsp_theia-integration_lib_browser_diagram_glsp-diagram-manager_-a838e9.bundle.js:1617:30)

[rsoika]

Finally I found the issue. It looks that it was the missing method createDefaultEdgeTypeHint in my BaseDiagramConfiguration

After I added the method like this:

   @Override
   public EdgeTypeHint createDefaultEdgeTypeHint(final String elementId) {
      EdgeTypeHint hint = super.createDefaultEdgeTypeHint(elementId);
      hint.setSourceElementTypeIds(
         Arrays.asList(ModelTypes.MANUAL_TASK));
      hint.setTargetElementTypeIds(
         Arrays.asList(ModelTypes.MANUAL_TASK));
      return hint;
   }

the error is gone and every thing works as expected.

By the way, this is one of two methods in the DiagramConfiguration Interface which are not documented in the source code. So I still do not know what the method is good for ;-)