-
I have a question about the versions of GLSP-Client and Sprotty. In my project I am based on the dependency
as far as I can see this binds the sprotty dependency
In the moment I am developing a lot about Routing and I have seen that there were some changes in sprotty in version 0.11.0 and 0.11.1 which also affects Routing. Now I ask myself if sprotty version 0.11.1 would show different behaviour in my project and if I am currently working on problems which may have been already solved...? Is it possible that I upgrade sprotty to version 0.11.1 in my project? I guess this is not compatible with eclipse-glsp/client 0.9.0 ? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 8 replies
-
You are right version 0.9.0 of GLSP is only compatible with sprotty version 0.10.0. The reason for this is that sprotty introduced a complete overhaul of their action definitions with 0.11.0 (switching from a class based approach to an interface+namespace based approach) and deprecated the old way of defining actions. If you want you could try to upgrade to the current nightly/next versions of both projects to see if you issue is resolved: Keep in mind that you probably need some adaptions to your code to resolve compilation errors. This will mostly affect action creation and type checking: // Creating a new action
//pre. 0.11.0
new SelectionAction(["elementToSelect"],[])
//new approach
SelectAction.create({selectedElementIDs: ["elementToSelect"]})
// Typchecking
//pre 0.11.0
if (isSelectAction(actionToTest)){
...
}
// new approach
if (SelectAction.is(actionToTest)){
...
}
|
Beta Was this translation helpful? Give feedback.
-
Hi @rsoika, "resolutions": {
"**/@eclipse-glsp/theia-integration": "0.10.0-next.a2c1ac1.122",
"**/@eclipse-glsp/client": "0.10.0-next.385713d.170",
"**/@theia/core": "1.20.0",
"**/@theia/editor": "1.20.0",
"**/@theia/filesystem": "1.20.0",
"**/@theia/markers": "1.20.0",
"**/@theia/messages": "1.20.0",
"**/@theia/monaco": "1.20.0",
"**/@theia/navigator": "1.20.0",
"**/@theia/outline-view": "1.20.0",
"**/@theia/preferences": "1.20.0",
"**/@theia/process": "1.20.0",
"**/@theia/terminal": "1.20.0",
"**/@theia/variable-resolver": "1.20.0",
"**/@theia/userstorage": "1.20.0",
"**/@theia/workspace": "1.20.0",
"**/@theia/cli": "1.20.0",
"**/inversify": "5.1.1"
} This ensures that exactly one version gets resolved during building. FYI : The I also saw that you are using a |
Beta Was this translation helpful? Give feedback.
You are right version 0.9.0 of GLSP is only compatible with sprotty version 0.10.0. The reason for this is that sprotty introduced a complete overhaul of their action definitions with 0.11.0 (switching from a class based approach to an interface+namespace based approach) and deprecated the old way of defining actions.
In the meantime we have adapted this approach for GLSP and the nightly version of GLSP is compatible with the current sprotty nightly (potentially also 0.11.1 but that has not been tested).
If you want you could try to upgrade to the current nightly/next versions of both projects to see if you issue is resolved:
https://www.npmjs.com/package/@eclipse-glsp/client/v/0.10.0-nex…