GLSP VS Code integration standalone example can't find dependencies #671

gee4vee · 2022-06-01T18:11:16Z

gee4vee
Jun 1, 2022

We are trying to use the workflow vs code example by itself and getting this when executing yarn in the extension directory. It appears it can't find the vscode-integration dependencies. We can only get this to work when we build from the parent directories which include the source code for the integration glue. However, I didn't expect that to be necessary since the dependencies are published. We are starting work on our own extension and would not want to include the glue code in our repository.

yarn install v1.22.17
[1/4] 🔍  Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "sprotty@~0.11.1"
[2/4] 🚚  Fetching packages...
warning Pattern ["@eclipse-glsp/protocol@next"] is trying to unpack in the same destination "/Users/gvalenc/Library/Caches/Yarn/v6/npm-@eclipse-glsp-protocol-0.10.0-next.aa813a8.174-1da96832417755892015fd6b69087b7b17344d54-integrity/node_modules/@eclipse-glsp/protocol" as pattern ["@eclipse-glsp/[email protected]+aa813a8"]. This could result in non-deterministic behavior, skipping.
[3/4] 🔗  Linking dependencies...
warning "@eclipse-glsp/config > @eclipse-glsp/[email protected]" has unmet peer dependency "@types/node@>=12.x".
warning "@eclipse-glsp/config > @eclipse-glsp/[email protected]" has unmet peer dependency "reflect-metadata@>=0.1.13".
warning "@eclipse-glsp/config > @eclipse-glsp/mocha-config > [email protected]" has unmet peer dependency "@types/node@*".
[4/4] 🔨  Building fresh packages...
warning Your current version of Yarn is out of date. The latest version is "1.22.19", while you're on "1.22.17".
info To upgrade, run the following command:
$ curl --compressed -o- -L https://yarnpkg.com/install.sh | bash
$ yarn clean && yarn build && yarn lint
yarn run v1.22.17
$ rimraf lib tsconfig.tsbuildinfo
✨  Done in 0.33s.
yarn run v1.22.17
$ tsc  && yarn download:Server
src/workflow-editor-provider.ts:16:37 - error TS2307: Cannot find module '@eclipse-glsp/vscode-integration' or its corresponding type declarations.

16 import { GlspVscodeConnector } from '@eclipse-glsp/vscode-integration';
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/workflow-editor-provider.ts:17:36 - error TS2307: Cannot find module '@eclipse-glsp/vscode-integration/lib/quickstart-components' or its corresponding type declarations.

17 import { GlspEditorProvider } from '@eclipse-glsp/vscode-integration/lib/quickstart-components';
                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/workflow-editor-provider.ts:25:9 - error TS4112: This member cannot have an 'override' modifier because its containing class 'WorkflowEditorProvider' does not extend another class.

25         protected override readonly glspVscodeConnector: GlspVscodeConnector
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/workflow-extension.ts:16:53 - error TS2307: Cannot find module '@eclipse-glsp/vscode-integration' or its corresponding type declarations.

16 import { GlspVscodeConnector, NavigateAction } from '@eclipse-glsp/vscode-integration';
                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/workflow-extension.ts:21:8 - error TS2307: Cannot find module '@eclipse-glsp/vscode-integration/lib/quickstart-components' or its corresponding type declarations.

21 } from '@eclipse-glsp/vscode-integration/lib/quickstart-components';
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/workflow-extension.ts:59:9 - error TS2345: Argument of type 'WorkflowEditorProvider' is not assignable to parameter of type 'CustomTextEditorProvider | CustomReadonlyEditorProvider<CustomDocument> | CustomEditorProvider<CustomDocument>'.

59         new WorkflowEditorProvider(context, glspVscodeConnector),
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 6 errors in 2 files.

Errors  Files
     3  src/workflow-editor-provider.ts:16
     3  src/workflow-extension.ts:16
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

planger · 2022-06-01T18:57:28Z

planger
Jun 1, 2022
Maintainer

Hi Gabriel,

please have a look at the vscode-node-json project template for a standalone example. The workflow example is more of a development example for GLSP developers to test, as well as to demonstrate certain repo-specific features.

In contrast, the project templates (like the one linked above) is the best place to find a self-contained GLSP example, which is correctly configured, for the respective combinations of integrations (VS Code, Eclipse Theia, JSON, EMF, Java, Node, etc.).

If you don't mind, I'd transfer this issue to the Q&A discussions. Feel free to reopen, if you object.

0 replies

gee4vee · 2022-06-02T16:14:57Z

gee4vee
Jun 2, 2022
Author

@planger Thank you for pointing us to the template! I grabbed the code and I'm getting this error during yarn build. Any idea what I need to do to fix it?

$ webpack
asset tasklist-glsp-server-packed.js 1.45 MiB [emitted] (name: main) 1 related asset
runtime modules 937 bytes 4 modules
modules by path ./node_modules/ 1.2 MiB 376 modules
modules by path ./lib/ 35.8 KiB
  modules by path ./lib/handler/*.js 14.6 KiB 5 modules
  modules by path ./lib/model/*.js 12 KiB
    ./lib/model/tasklist-model-state.js 2.42 KiB [built] [code generated]
    + 4 modules
  modules by path ./lib/*.js 2.84 KiB
    ./lib/index.js 990 bytes [built] [code generated]
    ./lib/app.js 1.88 KiB [built] [code generated]
  modules by path ./lib/diagram/*.js 6.39 KiB
    ./lib/diagram/tasklist-diagram-module.js 4.08 KiB [built] [code generated]
    ./lib/diagram/tasklist-diagram-configuration.js 2.31 KiB [built] [code generated]
+ 18 modules

ERROR in ./node_modules/color-string/index.js 3:14-39
Module not found: Error: Can't resolve 'simple-swizzle' in '/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/color-string'
resolve 'simple-swizzle' in '/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/color-string'
  Parsed request is a module
  using description file: /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/color-string/package.json (relative path: .)
    resolve as module
      /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/color-string/node_modules doesn't exist or is not a directory
      /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules
        single file module
          using description file: /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/package.json (relative path: ./node_modules/simple-swizzle)
            no extension
              /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/simple-swizzle doesn't exist
            .ts
              /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/simple-swizzle.ts doesn't exist
            .tsx
              /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/simple-swizzle.tsx doesn't exist
            .js
              /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/simple-swizzle.js doesn't exist
        /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/glsp-server/node_modules/simple-swizzle doesn't exist
      /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-vscode-client/node_modules doesn't exist or is not a directory
      /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/node_modules doesn't exist or is not a directory
      /Users/gvalenc/git/DevX/node_modules doesn't exist or is not a directory
      /Users/gvalenc/git/node_modules doesn't exist or is not a directory
      /Users/gvalenc/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./node_modules/color/index.js 3:18-41
 @ ./node_modules/colorspace/index.js 3:12-28
 @ ./node_modules/@dabh/diagnostics/modifiers/namespace-ansi.js 1:17-38
 @ ./node_modules/@dabh/diagnostics/node/development.js 29:19-57
 @ ./node_modules/@dabh/diagnostics/node/index.js 7:2-46
 @ ./node_modules/winston/lib/winston/exception-handler.js 12:14-42
 @ ./node_modules/winston/lib/winston.js 47:0-65
 @ ./node_modules/@eclipse-glsp/server-node/lib/di/app-module.js 20:16-34
 @ ./node_modules/@eclipse-glsp/server-node/lib/index.js 37:13-39
 @ ./lib/app.js 19:22-58
 @ ./lib/index.js 19:14-30

webpack 5.72.0 compiled with 1 error in 3413 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

1 reply

planger Jun 2, 2022
Maintainer

@tortmayr Can you please take a look at that? If I run git clean -xfd on current master before running yarn build, I actually get the same error for the node-json-vscode project template. Thanks!

gee4vee · 2022-06-02T16:37:25Z

gee4vee
Jun 2, 2022
Author

node and npm versions:

~/g/D/s/glsp-vscode-client [cs-vscode-extension-merge]{73} ⛈️ »  node -v                                             {11:14:07}
v16.14.0
@   api:cloud   R:us-south
~/g/D/s/glsp-vscode-client [cs-vscode-extension-merge]{73} ⛈️ »  npm -v                                              {11:37:04}
8.3.1

0 replies

gee4vee · 2022-06-02T16:55:59Z

gee4vee
Jun 2, 2022
Author

I'm able to get it to build with node 14.x. Are we limited to that version of node?

3 replies

planger Jun 2, 2022
Maintainer

Right, me too. Node 12.x and 14.x work fine. I'm not sure what the root cause of this error is. I was under the assumption that anything above (including) 12.x should work. I think it'd be best to wait for the feedback of @tortmayr who probably knows best what the potential reasons could be.

tortmayr Jun 3, 2022
Maintainer

Hi, Node 12 has reached its End-of-Life phase and is no longer actively supported with security updates. I highly recommend to use one of the current LTS versions (14 or 16) instead. In this case the limitation does come from VS Code rather than GLSP. VS Code and the VS Code extension API are no longer compatible with node 12 and require at least node 14 afaik.

planger Jun 3, 2022
Maintainer

Right, thanks! Good to know that we should remove 12.x.
Regarding the error above though, the error appears when building with 16.x, but doesn't appear when building with 12.x or 14.x. So there is something wrong with the build for 16.x.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GLSP VS Code integration standalone example can't find dependencies #671

{{title}}

Replies: 4 comments 4 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

GLSP VS Code integration standalone example can't find dependencies #671

gee4vee Jun 1, 2022

Replies: 4 comments · 4 replies

planger Jun 1, 2022 Maintainer

gee4vee Jun 2, 2022 Author

planger Jun 2, 2022 Maintainer

gee4vee Jun 2, 2022 Author

gee4vee Jun 2, 2022 Author

planger Jun 2, 2022 Maintainer

tortmayr Jun 3, 2022 Maintainer

planger Jun 3, 2022 Maintainer

gee4vee
Jun 1, 2022

Replies: 4 comments 4 replies

planger
Jun 1, 2022
Maintainer

gee4vee
Jun 2, 2022
Author

planger Jun 2, 2022
Maintainer

gee4vee
Jun 2, 2022
Author

gee4vee
Jun 2, 2022
Author

planger Jun 2, 2022
Maintainer

tortmayr Jun 3, 2022
Maintainer

planger Jun 3, 2022
Maintainer