Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle CLI tool #1363

Open
tortmayr opened this issue Jul 7, 2024 · 1 comment
Open

Bundle CLI tool #1363

tortmayr opened this issue Jul 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Jul 7, 2024

Currently we publish the @eclipse-glsp/cli tool unbundled. This is rather uncommon for plain CLI application. Every downstream project that consumes the cli tool also has to download all its dev dependencies. The CLI package has a mix of esm and commonjs dependencies which can lead to some wierd resolutions erros when consumed downstream. Bundling the CLI tool with e.g. eslint would get rid of that problem.

@tortmayr tortmayr added the enhancement New feature or request label Jul 7, 2024
tortmayr added a commit that referenced this issue Jul 7, 2024
Bundle CLI tool with eslint
Also: Update tsconfig target to ES2019 to be in line with Theia
#1363
tortmayr added a commit that referenced this issue Jul 8, 2024
Bundle CLI tool with eslint
Also: Update tsconfig target to ES2019 to be in line with Theia
#1363
tortmayr added a commit that referenced this issue Jul 8, 2024
Bundle CLI tool with eslint
Also: Update tsconfig target to ES2019 to be in line with Theia
#1363
@tortmayr
Copy link
Contributor Author

tortmayr commented Jul 9, 2024

Currently this is blocked by due to an issue in shelljs: shelljs/shelljs#1161
I will continue working on this once a fix is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant