Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All, Undo, Redo not working in auto-complete and palette filter input #1390

Open
planger opened this issue Aug 20, 2024 Discussed in #1389 · 4 comments
Open

Select All, Undo, Redo not working in auto-complete and palette filter input #1390

planger opened this issue Aug 20, 2024 Discussed in #1389 · 4 comments

Comments

@planger
Copy link
Member

planger commented Aug 20, 2024

Discussed in #1389

Originally posted by vibsid0986 August 16, 2024
Hello Team,

I was working on workflow-glsp examples and observed that when we double click on a node and Autocomplete widget opens, select all, undo and redo are not working in there, even their corresponding key bindings seems to select the complete workflow example widget instead of the text in the autocomplete widget. Please see below image when I did Ctrl + A on the node with text "ABC", it selects the complete widget.

Request you to help me in resolving this issue, as I need to implement select all, undo, redo for my custom use case.

Thanks in advance.

image

@tortmayr
Copy link
Contributor

Seems to be a Theia-integration specific problem. Works as expected in the standalone workflow example

@vibsid0986
Copy link

Hi,

I am using@eclipse-glsp/theia-integration": "2.0.0" with theia version : 1.43.1.

is this issue related to the version specified or an implementation issue ??

@vibsid0986
Copy link

Hi @planger ,

Can you please guide me as to how I can fix this issue.

Thanks in advance,
Siddhant

@planger
Copy link
Member Author

planger commented Oct 15, 2024

I didn't get to debugging this in detail, but it looks like those events are coming from Theia and are forwarded to the GLSP Theia integration, which then directly acts as if the diagram should handle those, when in fact some input field has focus and should handle those events.

I assume we need to check the GLSP Keybinding Context and only activate it if the diagram has focus, but not if an input field has focus.

This bug may have been introduced by a rather recent move of the UI extensions into the diagram container, but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants