Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #518 (Setting a breakpoint inside lambda with object). #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nettozahler
Copy link

What it does

Fixes #518

How to test

Try to set a breakpoint inside a lambda expression with its body beginning with an anonymous class declaration.
See #518 as example. The new breakpoint should appear as usual and jumping to it from inside the "breakpoint view" must work.

Author checklist

@nettozahler nettozahler marked this pull request as draft October 1, 2024 13:43
@nettozahler
Copy link
Author

Maybe it would be good to extend the existing tests for this case.

@nettozahler
Copy link
Author

Review should consider this:
Lambda body can be a block or an (arbitrary) expression. So maybe the cases which are handled in the code are insufficient and should be replaced by handling the general org.eclipse.jdt.core.dom.Expression (see my similar comment in changed Java file).

@nettozahler nettozahler marked this pull request as ready for review October 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a breakpoint inside a lamda that contains an object fails
1 participant