Unanticipated comparator errors in pde.doc in I20241002-1800

[jarthana]

The report is here:

https://download.eclipse.org/eclipse/downloads/drops4/I20241002-1800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

Noticed we had just touched the affected bundles last week. Not sure if this is similar.
First few lines of the report:

Comparator differences from current build
	/home/jenkins/agent/workspace/Builds/I-build-4.34/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20241002-1800
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.34-I-builds

1.  eclipse.pde/org.eclipse.pde.doc.user/pom.xml
   no-classifier: different
      reference/api/deprecated-list.html: different
      reference/api/index-files/index-18.html: different
      reference/api/index-files/index-3.html: different
      reference/api/index-files/index-7.html: different
      reference/api/index-files/index-9.html: different

[merks]

Here are details of the differences:

diff.txt

It looks like many cross reference links have disappeared which can't be a good thing.

[akurtakov]

That's weird so they are no longer links?

[merks]

Yes, no longer links it appears. Maybe this change to the javadoc caused a problem/change?

eclipse-platform/eclipse.platform.releng.aggregator@203abf0

[merks]

It's like these offline links are not being processed properly:

[akurtakov]

It's another problem https://www.eclipse.org/downloads/download.php?file=/eclipse/updates/4.34-I-builds/I20241002-1800/plugins/org.eclipse.platform.doc.isv_4.34.0.v20241002-0922.jar doesn't contain reference/api thus it's impossible to make it offlineLink. Now, it's up to find why building it failed silently.

[merks]

I see. Good we investigated and didn't just bump the version blindly!

[HannesWell]

It's another problem https://www.eclipse.org/downloads/download.php?file=/eclipse/updates/4.34-I-builds/I20241002-1800/plugins/org.eclipse.platform.doc.isv_4.34.0.v20241002-0922.jar doesn't contain reference/api thus it's impossible to make it offlineLink. Now, it's up to find why building it failed silently.

Reminds me of #1402. Maybe the output directory changed again? Maybe we should set it explicitly.

[akurtakov]

It didn't change again but the fix went only pde.docs and there were no changes in platform so it wasn't caught by now.

[HannesWell]

It didn't change again but the fix went only pde.docs and there were no changes in platform so it wasn't caught by now.

Yes. When doing this change it was mentioned that it would probably be necessary for the other ones as well:

• Adapt to changed output directory in maven-javadoc-plugin 3.10.0 #1402 (comment)

But since no error was shown I assumed it works in the other doc-bundles for some other magic reason.
I really wonder why this only surfaced three weeks later?
The update to maven-javadoc-plugin 3.10 was actually globally:

• fix(deps): bump org.apache.maven.plugins:maven-javadoc-plugin from 3.8.0 to 3.10.0 in /eclipse-platform-parent eclipse-platform/eclipse.platform.releng.aggregator#2266

Anyways. Thanks for the fix!

[akurtakov]

I-build succeeded https://download.eclipse.org/eclipse/downloads/drops4/I20241003-0820/