Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern light theme: inactive Console View Tab looks odd #2197

Closed
jukzi opened this issue Aug 15, 2024 · 8 comments
Closed

modern light theme: inactive Console View Tab looks odd #2197

jukzi opened this issue Aug 15, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 15, 2024

reproduce:

  1. disable "Show console" (automatically), switch to another view.
    image

  2. log something to Console

  3. => "Console" becomes highlighted (bold, black) indicating pending output. With the new theme that feels/looks like Console is the active View but it is not. Screenshot:
    image

With the old Scheme it was a also highlighted but it was obvious that it is not the title of the active view, because the active view tab was highlighted by the background color:
image
#2114 @thomasritter

The UI needs to have a single consistent pattern what highlights the active View. I.e. either backgroundcolor or textcolor and must not mix that highlighting with other usecases

@jukzi jukzi added the bug Something isn't working label Aug 15, 2024
@Phillipus
Copy link
Contributor

Phillipus commented Aug 15, 2024

Possibly related #2114 (comment) and #2114 (comment)

@BeckerWdf
Copy link
Contributor

The UI needs to have a single consistent pattern what highlights the active View. I.e. either backgroundcolor or textcolor and must not mix that highlighting with other usecases

It does with the blue underlining...

@jukzi
Copy link
Contributor Author

jukzi commented Aug 16, 2024

single consistent pattern

It does with the blue underlining...

that is only one of multiple. For the inactive Editors the text color is also changed (and is not a blue underline but a blue overline).

@BeckerWdf
Copy link
Contributor

and is not a blue underline but a blue overline

Really?

@jukzi
Copy link
Contributor Author

jukzi commented Aug 16, 2024

Really?

see:
image

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Aug 16, 2024

It started to appear like this for me today as well. Until yesterday, the highlight was always at the tab's bottom.

Even worse, the highlight at the top appears to be smaller in the dark theme, which makes it hardly visible for the active tab that has focus:
image

Edit: Just saw that it should have already been like this for quite some time, but for some reasons my SDK first changed today, even though I update it via Oomph on a daily basis and always properly get other changes in.

@jukzi
Copy link
Contributor Author

jukzi commented Sep 3, 2024

With light theme (preview) it is very confusing which tab is hovered/active:
For the editors a mouse hover highlights the tab, while it dimms the tab on a hover in the breakpoints/variables view:
image
image

@BeckerWdf
Copy link
Contributor

The UI needs to have a single consistent pattern what highlights the active View. I.e. either backgroundcolor or textcolor and must not mix that highlighting with other usecases

From my point of view this is address with #2286.
Pls. reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants