Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to expand/collapse items in the explorer without impacting the selection #1062

Open
pcdavid opened this issue Feb 11, 2022 · 1 comment · Fixed by #1063 · May be fixed by #4084
Open

It should be possible to expand/collapse items in the explorer without impacting the selection #1062

pcdavid opened this issue Feb 11, 2022 · 1 comment · Fixed by #1063 · May be fixed by #4084
Assignees
Milestone

Comments

@pcdavid
Copy link
Member

pcdavid commented Feb 11, 2022

Currently clicking on the ">" marker of an item in the explorer to expand it and see its children automatically selects it.
This can be annoying as this changes the contents of the details view, and possibly moves things around to focus on the newly selected element if it is visible on an open diagram.
In some contexts (e.g. when details are costly to compute) this can also have performance impact.

It should be possible to expand and collapse a tree item without selecting it if the user clicks on the icon (if navigating and expanding/collapsing using the keyboard, one has to already have the item selected to expand/collapse it, so it's not really possible in this case).

@pcdavid pcdavid self-assigned this Feb 11, 2022
pcdavid added a commit that referenced this issue Feb 11, 2022
pcdavid added a commit that referenced this issue Feb 11, 2022
pcdavid added a commit that referenced this issue Feb 14, 2022
pcdavid added a commit that referenced this issue Feb 15, 2022
pcdavid added a commit that referenced this issue Feb 15, 2022
@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Feb 15, 2022
@pcdavid pcdavid reopened this Oct 7, 2024
@pcdavid pcdavid modified the milestones: 2022.3.0, 2024.11.0 Oct 7, 2024
@pcdavid
Copy link
Member Author

pcdavid commented Oct 7, 2024

This was broken by the change made for #3056

pcdavid added a commit that referenced this issue Oct 9, 2024
This was originally fixed in 2022.3.0 via commit
48913d1, but broken again in
2024.3.0.

This reverts "[3056] Expand the clickable/draggable zone for tree
items" (commit 190b919) which caused
the regression.

Bug: #1062
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Oct 9, 2024
This was originally fixed in 2022.3.0 via commit
48913d1, but broken again in
2024.3.0.

This reverts "[3056] Expand the clickable/draggable zone for tree
items" (commit 190b919) which caused
the regression.

Bug: #1062
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Oct 9, 2024
This was originally fixed in 2022.3.0 via commit
48913d1, but broken again in
2024.3.0.

This reverts "[3056] Expand the clickable/draggable zone for tree
items" (commit 190b919) which caused
the regression.

Bug: #1062
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Oct 9, 2024
… when expanding/collapsing from the arrow/chevron

Bug: #1062
Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment