Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role names templated in base chart, and hardcoded in main chart #17

Open
askarbozcan opened this issue Mar 16, 2023 · 1 comment
Open
Assignees

Comments

@askarbozcan
Copy link
Contributor

In theia cloud (main) chart, names referenced service-role.yaml and operator-role.yaml are not templated and assume the default values from values.yaml in Theia cloud base.
Namely, operator-api-access and service-api-access.
Those are the default role names in base, however in base they can be templated.
In the main Theia cloud chart, the default role names are hardcoded.

@jfaltermeier
Copy link
Contributor

Thank you for the report. We will include a fix in the next milestone.

@jfaltermeier jfaltermeier self-assigned this Mar 17, 2023
jfaltermeier added a commit that referenced this issue Mar 28, 2023
* add values to configure monitor
* use names from values for operator/service role #17
jfaltermeier added a commit that referenced this issue Mar 28, 2023
* add values to configure monitor
* use names from values for operator/service role #17
jfaltermeier added a commit that referenced this issue Apr 20, 2023
* use names from values for operator/service role #17
jfaltermeier added a commit that referenced this issue Apr 20, 2023
* use names from values for operator/service role #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants