Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for certain quick fixes #528

Open
turkeylurkey opened this issue May 28, 2024 · 1 comment
Open

Add unit tests for certain quick fixes #528

turkeylurkey opened this issue May 28, 2024 · 1 comment
Labels
automated tests Related to automated integration or unit tests design

Comments

@turkeylurkey
Copy link
Contributor

turkeylurkey commented May 28, 2024

There are unit tests for some quick fixes but there are none for the following diagnostics.

Bean Validation

  • The @DecimalMax/@DecimalMin/@Digits annotation can only be used on: BigDecimal... etc.
  • The @Email annotation can only be used on String...
  • The @Min/@Max annotation can only be used on BigDecimal, ... etc
  • The @Negative/@NegativeOrZero/@Positive/@PositiveOrZero annotation can only be used on BigDecimal, ... etc
  • The @NotBlank/@Pattern annotation can only be used on String and CharSequence type fields or methods.
@mrglavas
Copy link

mrglavas commented May 29, 2024

WebSocket

  • A unit test exists for inserting the @PathParam annotation on to method parameters but does not verify all the code actions for all the diagnostics produced by the test resource. See io.openliberty.sample.jakarta.websocket.AnnotationTest and org.eclipse.lsp4jakarta.jdt.websocket.JakartaWebSocketTest.addPathParamsAnnotation(). The test should also verify the quick fixes for the public void OnClose(Session session, Integer missingAnnotation1, String missingAnnotation2) method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests Related to automated integration or unit tests design
Projects
None yet
Development

No branches or pull requests

2 participants