Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Chinese (zh_cn) environment, if displayed in week mode in GanttChart, incorrect date conversion may occur. #600

Open
liutaoPLM opened this issue Jun 18, 2024 · 1 comment

Comments

@liutaoPLM
Copy link

In the GanttComposite.java file of the package org. eclipse. newula. widgets. Ganttchart, in the getDate String method, DateHelper. getDate (cal, _settings. getWeekHeaderTextDisplayBottom()) performs string splitting on the return value, causing "星期一(Monday)" and "星期二(Tuesday)" to become "星" in the Chinese environment. This seems very unfriendly to Chinese users. Since I am using a lower version, I modified substring (0,1) to substring by decompiling. (2, 3), temporarily resolved this issue. I think the Gant diagram plugin is very good, so I hope this issue can be fixed in a new version.
Before making changes
QQ截图20240618185103
After making changes
QQ截图20240618190245
Thanks!

@liutaoPLM liutaoPLM changed the title In the Chinese (zh_cn) environment, if displayed in week mode in GanttChat, incorrect date conversion may occur. In the Chinese (zh_cn) environment, if displayed in week mode in GanttChart, incorrect date conversion may occur. Jun 18, 2024
@merks
Copy link
Contributor

merks commented Jun 19, 2024

Is this something to which you could contribute a fix? It's very easy to set up a development environment:

https://github.com/eclipse/nebula?tab=readme-ov-file#setup-a-development-enviroment

I think you mean this line:

image

I have no idea why it's taking just the first character. That doesn't seem very locale sensitive, but doubt hard coding (2, 3) is going to be correct in all cases either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants