Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans with Trial periods don't return as "success" #73

Closed
pmoignard opened this issue Mar 24, 2020 · 5 comments
Closed

Plans with Trial periods don't return as "success" #73

pmoignard opened this issue Mar 24, 2020 · 5 comments

Comments

@pmoignard
Copy link

Plans with Trial periods in Stripe don't fire a "success" state when form is submitted. Works fine for plans without a trial.

@edalzell
Copy link
Owner

@pmoignard does the subscription get created properly with the trial?

@pmoignard
Copy link
Author

pmoignard commented Mar 24, 2020

Yep. Seems to anyway. A subscription gets charged after the trial period as it should, and Charge adds all the necessary data and role to the user.

@pmoignard
Copy link
Author

Since you fixed this, the {{ sucesss }} message is scoping weird. When I have more than one form on a page, submitting the form fires all of the success messages instead of just the one in the form that was submitted.

@edalzell
Copy link
Owner

edalzell commented Apr 1, 2020

That's a separate issue opened an issue for it: #75

@pmoignard
Copy link
Author

Sounds good. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants