New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-timeline selection label is wrong #181

Open

DrRataplan opened this issue Aug 20, 2024 · 0 comments

Assignees

Contributor

DrRataplan commented Aug 20, 2024

To repro:

Visit https://koenigsfelden.sources-online.org/index.html?query=&sort=date&subtype=edition&subtype=title&subtype=regest&subtype=comment&subtype=notes&dates=&start=1
Observe the label (Angezeigter Zeitraum: 1270 – 1655)
Go to the last item in the timeline: 1655 - 1659 : 1
Actually click that item
Check the date of that single document: 01. Februar 1659

Expected:

The label should have been 1270 - 1659

Actual:

The label of the pb-timeline component indicates 1270 – 1655, whichis wrong

The fix is to use the selectionStart / selectionEnd fields in the data of the pb-timeline. PR incoming.

The text was updated successfully, but these errors were encountered:

DrRataplan self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment