-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: thumbnail strip with labels for pb-facsimile #85
Comments
Notes from our discusssion
Strip shows all facsimiles given to it List of thumbnails Communicates with OSD Must allow to pass in additional metadata Must be placeable at a different locations on the page
The new custom-element
We were looking at two use cases:
|
Use cases: Source of facsimiles and their labelsfacs-strip as an overview: all facsimiles available in the current transcription fragment
facs-strip as edition navigation
Let's imagine an edition organized in lengthy chapters (like Bible). The document view is organized with facing transcription/facsimile panels and page by page navigation. Nevertheless, to assist navigation, thumbnails strip with opening pages for each chapter is available at all times at the bottom. Organization of the strip
css properties:
linking/events sent from the thumbnail
other concerns
|
may i suggest to name the component 'pb-facs-thumbs'? '-strip' is a bit underspecified IMO |
further i suggest to create some usage examples (along with possible attributes)- how will the element used on the page? This avoids confusion during development. e.g.
or
i guess containment (first example) is more sensible and eases the positioning. However the positioning would be rather an enhancement to Hope that makes sense |
Naming thing is hard, so we should think about a good name. I think your suggestion does make sense but I also think that I would think that |
Very interesting suggestion @JoernT - I like it for easy placement. |
Even if contained in a slot it could be positioned anywhere with position=fixed. And i agree that the components should at least be thought of as being independent of pb-facs |
Typical markup when the list of thumbnails is retrieved from the <main>
<pb-view id="view1" src="document1"
subscribe="transcription" emit="transcription"
wait-for="#facsimile #thumbnails"/>
<pb-facsimile id="facsimile" base-uri="https://apps.existsolutions.com/cantaloupe/iiif/2/"
subscribe="transcription"/>
<pb-image-strip id="thumbnails" base-uri="https://apps.existsolutions.com/cantaloupe/iiif/2/"
subscribe="transcription" emit="transcription"
layout="horizontal" label-position="top"/>
</main> |
Markup example when the list of thumbnails comes from an API endpoint and there's no facsimile viewer as such, thumbnails act as a navigation control <main>
<pb-view id="view1" src="document1"
subscribe="transcription" emit="transcription"
wait-for="#facsimile"/>
<pb-load id="references" source="api/thumbnails/{doc}"
auto="auto"
load-once="load-once"
emit="transcription"
wait-for="#thumbnails"/>
<pb-image-strip id="thumbnails"
base-uri="https://apps.existsolutions.com/cantaloupe/iiif/2/"
emit="transcription"
layout="horizontal" label-position="top"/>
</main>
``` |
The existing code which causes Event handling
Backwards compatibilityShould not be an issue as we plug into existing events. Users should not notice the change. Just updating |
Moi @juri |
Specify label on <pb-facs-link facs="my-image.tif" label="Green Elephant">Page 14</pb-facs-link> Complex case: use template to allow block-level content: <pb-facs-link facs="my-image.tif">
Page 14
<template class="label">
<h3><pb-link path="other-doc.xml">Green Elephant</pb-link></h3>
<p>An image of a green elephant</p>
</template>
</pb-facs-link> |
@wolfgangmm I would assume that the image strip component also listens on |
@wolfgangmm Very good schematic BTW. That makes it easier to reason about. We also haven't finished the discussion on how the image strip component is notified of the list of pb-facsimile-links that are present in a |
or is that with |
@line-o yes, And also yes, |
refs #85 - pb-image-strip can be slotted into pb-facsimile - pb-facs-link emits 'pb-load-facsimile' - both pb-facsimile and pb-image-strip listen on 'pb-load-facsimile' - clicking on an image emits 'pb-show-annotation' - add standalone demo - add demo with pb-view
refs #85 - pb-image-strip can be slotted into pb-facsimile - pb-facs-link emits 'pb-load-facsimile' - both pb-facsimile and pb-image-strip listen on 'pb-load-facsimile' - clicking on an image emits 'pb-show-annotation' - add standalone demo - add demo with pb-view
# [2.1.0](v2.0.0...v2.1.0) (2023-03-16) ### Bug Fixes * **pb-facs-link:** wait for pb-facsimile or pb-image-strip to be ready ([93da282](93da282)) ### Features * **pb-facsimile:** respect facs-link order ([8754768](8754768)) * **pb-image-strip:** reverse default order ([ea12409](ea12409)) * pb-facs-link, pb-image-strip ([f667176](f667176)) * ** pb-image-strip:** sort items by order ([d0baa51](d0baa51)) * **pb-image-strip:** add new component ([9143856](9143856)), closes [#85](#85)
extend pb-facsimile reference strip feature with a way to specify a label for each of the thumbnails, like it is done in e.g. Ginzberg edition
The text was updated successfully, but these errors were encountered: