Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFNStateMachine Tag Support #415

Open
andrew-squire opened this issue Nov 12, 2024 · 3 comments
Open

SFNStateMachine Tag Support #415

andrew-squire opened this issue Nov 12, 2024 · 3 comments

Comments

@andrew-squire
Copy link

Hi,
We're currently utilising the __global__ filter for excluding resources with tags, which is working on the most part apart from SFNStateMachine. (Similar issue raised here)

Config file:

    filters:
      __global__:
        - property: tag:DoNotNuke
          value: "True"
        - property: tag:DoNotNuke
          value: "true"

State machine tags:
image

Dry run results:

us-east-1 - SFNStateMachine - arn:aws:states:us-east-1:<redacted>:stateMachine:self-aws-nuke - would remove

Hopefully an easy fix, thanks!

@ekristen
Copy link
Owner

It's just a matter of having the time to add it to the resource. There are many that don't support properties or tags, it's part of my goal to get parity where I can.

@andrew-squire
Copy link
Author

That's all good @ekristen! Just wanted to flag. Thanks for all your work giving this project the love it deserves, it's definitely noticed!

@ekristen
Copy link
Owner

I appreciate the kind words. More to come soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants