Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http client request body capturing 1024 byte limit #3788

Open
3 tasks
JonasKunz opened this issue Sep 9, 2024 · 0 comments
Open
3 tasks

Remove http client request body capturing 1024 byte limit #3788

JonasKunz opened this issue Sep 9, 2024 · 0 comments
Assignees

Comments

@JonasKunz
Copy link
Contributor

JonasKunz commented Sep 9, 2024

We would like to extend the HTTP client request body capturing feature to support more than 1024 bytes.
The 1024 bytes limit currently comes from the fact that we send the content as otel.attribute in Intakev2, which only supports 1024 bytes.

Therefore we'll have to extend the Intakev2 protocol with a separate field which doesn't have this limitation, like we already do for transactions.

  • Add support for http.request.body intakev2 field to spans (copy it from transactions request.body)
  • Send the http client requests bodies in http.request.body instead of otel.attributes
  • Drop the 1024 bytes limitation when capturing the bodies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant