-
Notifications
You must be signed in to change notification settings - Fork 12
PR Comment Templates
Richard van der Hoff edited this page Feb 3, 2023
·
3 revisions
This intends to be a collection of saved replies that can be given on GitHub interactions such as Pull Requests or Issues. Until GitHub supports per-org/repo saved replies, you can c+p these into your own saved replies in https://github.com/settings/replies
Items can be removed from bulleted lists if not appropriate to he PR in question.
Thanks for the PR! However, there are some things that need fixing about it. We encourage you to read [CONTRIBUTING.md](https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md) which gives instructions on how to make a good pull request. Looking at the format of other pull requests on the repository should help too. In particular, remember:
* Your PR title will appear in the changelog: make sure it's a good, short description of what your PR does.
* If it fixes an issue, use standard GitHub syntax ("fixes [link to issue]") in the description (not in the title).
* Visual changes needs before and after screenshots.
* Your PR needs DCO signoff. Checking the check box is not sufficient.
We'd welcome a new PR after fixing these issues.
Thanks for your contribution. I'm going to close this for now as the changes requested haven't been made. If you're interested in continuing to work on this please let us know and we can reopen the pull request. Thanks!