Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test which ensures that new tables get PRIMARY KEYs. #16648

Open
matrixbot opened this issue Dec 21, 2023 · 0 comments
Open

Add a test which ensures that new tables get PRIMARY KEYs. #16648

matrixbot opened this issue Dec 21, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #16648.


We have a history, even recently, of not using PRIMARY KEYs and many of the cases seem tragically just because someone was unaware that it is good practice / maybe cribbed off earlier schema deltas. In many cases a UNIQUE index was created instead when that could've been a PRIMARY KEY.

This PR adds a test that flags up missing PRIMARY KEYs.

Base: develop

Original commit schedule, with full messages:

  1. Add a PRIMARY KEY lint

@matrixbot matrixbot changed the title Dummy issue Add a test which ensures that new tables get PRIMARY KEYs. Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant