Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/createRoom's creation_content should be validated against the event schema, and rejected if invalid #17845

Open
turt2live opened this issue Oct 17, 2024 · 0 comments

Comments

@turt2live
Copy link
Member

Description

When creating a room via /createRoom, creation_content can be specified to append information to the m.room.create event in the room. For known fields like predecessor, it can be important that the correct value type is used, otherwise there may be issues downstream.

Synapse should validate the fields it knows about, and continue to accept unknown fields verbatim.

Related: #13664

Steps to reproduce

  • Create a room with predecessor: "some string" instead of predecessor: { object required by spec }

Homeserver

matrix.org

Synapse Version

matrix.org

Installation Method

Other (please mention below)

Database

postgresql

Workers

Multiple workers

Platform

matrix.org

Configuration

No response

Relevant log output

matrix.org

Anything else that would be useful to know?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant