Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConfigController] Fixed an exception on config load #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ConfigController] Fixed an exception on config load #20

wants to merge 1 commit into from

Conversation

MyZik
Copy link

@MyZik MyZik commented Apr 13, 2022 •
edited
Loading

msphn
msphn suggested changes Apr 13, 2022
View reviewed changes
src/Controller/ConfigController.php Outdated
if ($configuration && isset($configuration->configuration->general->executor)) {
if (
isset($configuration->configuration->general->executor) &&
!empty($configuration->configuration->general->executor)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use class_exists?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also using empty and isset is a little redundant, you could just use !empty && class_exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msphn msphn msphn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Class "" not found
2 participants
@MyZik @msphn